Skip to content

Remove extra kind yaml key#711

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
shoudusse:fix-acme-dns-doc-typo
Oct 7, 2021
Merged

Remove extra kind yaml key#711
jetstack-bot merged 1 commit intocert-manager:masterfrom
shoudusse:fix-acme-dns-doc-typo

Conversation

@shoudusse
Copy link
Contributor

@shoudusse shoudusse commented Oct 6, 2021

Fix typo in yaml !

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Oct 6, 2021
@netlify
Copy link

netlify bot commented Oct 6, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 46c2803

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/615dcdbe3d50fa00070d870f

😎 Browse the preview: https://deploy-preview-711--cert-manager-website.netlify.app/docs/configuration/acme/dns01/acme-dns

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 6, 2021

Hi @shoudusse. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2021
@shoudusse
Remove extra kind yaml key
46c2803 
Signed-off-by: Sylvain Houdusse <syh@slyweb.org>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 6, 2021
@shoudusse
Copy link
Contributor Author

shoudusse commented Oct 7, 2021

/assign @jakexks

jakexks
jakexks approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, shoudusse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021
@jetstack-bot jetstack-bot merged commit 19938ab into cert-manager:master Oct 7, 2021
@shoudusse shoudusse deleted the fix-acme-dns-doc-typo branch October 7, 2021 12:37
@jetstack-bot jetstack-bot mentioned this pull request Oct 19, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shoudusse @jetstack-bot @jakexks